Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/update: update homebrew/core and homebrew/cask with devcmdrun. #15625

Merged
merged 1 commit into from Jul 4, 2023
Merged

cmd/update: update homebrew/core and homebrew/cask with devcmdrun. #15625

merged 1 commit into from Jul 4, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 4, 2023 •
edited

If those folks have this tapped and explicitly run brew update: let's update it for them.

@MikeMcQuaid
cmd/update: update homebrew/core and homebrew/cask with devcmdrun.
93a6335 
If those folks have this tapped and explicitly run `brew update`:
let's update it from them.
@MikeMcQuaid MikeMcQuaid requested a review from Bo98 July 4, 2023 14:59
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 4, 2023
Merged
Bo98
Bo98 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reporter of #15621 had HOMEBREW_DEV_CMD_RUN but had a stale 5 month old homebrew-core.

I'm fine with this for now but in the long term we probably want something better.

@Bo98 Bo98 enabled auto-merge July 4, 2023 15:05
@Bo98 Bo98 merged commit 1ba1d7b into Homebrew:master Jul 4, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member Author

The reporter of #15621 had HOMEBREW_DEV_CMD_RUN but had a stale 5 month old homebrew-core.

Thanks for context. I think in that case we do probably want to update or untap.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
@MikeMcQuaid MikeMcQuaid deleted the update_devcmdrun branch September 27, 2023 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @Bo98