Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insist on using macOS texinfo #15681

Merged
merged 1 commit into from Jul 18, 2023
Merged

Conversation

fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Jul 15, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

macOS texinfo is left at an old version, and is not present on newer version (Ventura and later). We have migrated all of homebrew-core versions to using Homebrew's texinfo when necessary (like in Homebrew/homebrew-core#114068 and friends), but the audit still triggers in some cases: Homebrew/homebrew-core#135322

It's high time we stop insisting on using macOS texinfo. I actually thought I had done that already a couple of months ago :)

@fxcoudert
Copy link
Member Author

Audit does not deal with texinfo being keg-only only on some macOS versions. Either we ignore the audit, or we make texinfo not-keg-only. I'm all for the second (simplify maintenance across macOS versions). Opinions?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-linnane
Copy link
Member

Audit does not deal with texinfo being keg-only only on some macOS versions. Either we ignore the audit, or we make texinfo not-keg-only. I'm all for the second (simplify maintenance across macOS versions). Opinions?

Agreed with the second option. Better to improve things moving forward.

@fxcoudert
Copy link
Member Author

Opened companion PR in homebrew-core: Homebrew/homebrew-core#136838

@MikeMcQuaid MikeMcQuaid merged commit d82d525 into Homebrew:master Jul 18, 2023
24 checks passed
@fxcoudert fxcoudert deleted the texinfo branch July 18, 2023 07:10
@MikeMcQuaid
Copy link
Member

Thanks @fxcoudert!

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants