dev-cmd/generate-*-api: be a bit safer. #15704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
approved these changes
Jul 18, 2023
Bo98
reviewed
Jul 18, 2023
MikeMcQuaid
force-pushed
the
generate_api_safer
branch
from
64443d3
to
258f9e2
Compare
- also try generating formula API on macOS - pull more logic out of `unless args.dry_run?` in case it fails
MikeMcQuaid
force-pushed
the
generate_api_safer
branch
from
258f9e2
to
e1a7afb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unless args.dry_run?in case it fails