Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: don't set HOMEBREW_NO_INSTALL_FROM_API automatically. #15868

Merged

Conversation

MikeMcQuaid
Copy link
Member

My understanding is that now #15778 has been merged this should now work fine on both older macOS versions and non-default prefixes so let's try this again.

Maintainers: if we get user reports for this breaking things from source on unsupported configurations (i.e. users with non-default prefixes or old macOS versions) try to fix forward if possible but feel free to insta-revert if it causes any issues with any of our CI.

CC @Bo98 @gerlero FYI

My understanding is that now #15778
has been merged this should now work fine on both older macOS versions
and non-default prefixes so let's try this again.
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid merged commit 98c8dd0 into Homebrew:master Aug 15, 2023
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the more_install_from_api_again branch August 15, 2023 13:27
@gerlero
Copy link
Contributor

gerlero commented Aug 15, 2023

Thanks! It's working now

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants