New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the policy on static libraries #15870
Merged
MikeMcQuaid
merged 4 commits into
Homebrew:master
from
SMillerDev:chore/docs/say_no_to_static
Aug 15, 2023
Merged
Document the policy on static libraries #15870
MikeMcQuaid
merged 4 commits into
Homebrew:master
from
SMillerDev:chore/docs/say_no_to_static
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Aug 15, 2023
carlocab
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok by me after s/can not/cannot/
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
ZhongRuoyu
approved these changes
Aug 15, 2023
p-linnane
reviewed
Aug 15, 2023
Co-authored-by: Patrick Linnane <patrick@linnane.io>
MikeMcQuaid
reviewed
Aug 15, 2023
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
MikeMcQuaid
approved these changes
Aug 15, 2023
MikeMcQuaid
changed the title
chore: document the policy on static libraries
Document the policy on static libraries
Aug 15, 2023
Thanks again @SMillerDev! |
p-linnane
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?