cmd/update-report: improve tap/untap behaviour. #15878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MikeMcQuaid
commented
Aug 16, 2023
MikeMcQuaid
commented
- unify core tapping/untapping behaviour (so we can never tap and then immediately untap)
- automatically untap homebrew-core or homebrew-cask if it's old, on the default branch and it doesn't seem to be needed
- if we think it's unneeded but it's too new: output a message instead
carlocab
approved these changes
Aug 16, 2023
- unify core tapping/untapping behaviour (so we can never tap and then immediately untap) - automatically untap homebrew-core or homebrew-cask if it's old, on the default branch and it doesn't seem to be needed - if we think it's unneeded but it's too new: output a message instead Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
MikeMcQuaid
force-pushed
the
brew_update_untap
branch
from
e984568
to
2d133ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.