Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: rework Cask-Cookbook to match current practice #15933

Merged
merged 1 commit into from Sep 2, 2023
Merged

Docs: rework Cask-Cookbook to match current practice #15933

merged 1 commit into from Sep 2, 2023

Conversation

EricFromCanada
Copy link
Member

  • add or update example code and links
  • relocate and rework the Conditional Statements section to match how system versions and architectures are now handled in homebrew/cask
  • replace macOS symbols table with link to MacOSVersion class documentation
  • integrate most of the livecheck stanza section into the brew livecheck page and fill in a few gaps (cc @samford)

@EricFromCanada
docs: rework Cask-Cookbook to match current practice
4205cb4 
and migrate `livecheck` stanza documentation to Brew-Livecheck.md
MikeMcQuaid
MikeMcQuaid approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit 9b76182 into Homebrew:master Sep 2, 2023
24 checks passed
@EricFromCanada EricFromCanada changed the title docs: rework Cask-Cookbook to match current practice Docs: rework Cask-Cookbook to match current practice Sep 5, 2023
@EricFromCanada EricFromCanada deleted the docs-cask-cookbook-reorg branch September 11, 2023 16:28
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricFromCanada @MikeMcQuaid