Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ARGV from Formula#all #15934

Merged
merged 1 commit into from Sep 2, 2023
Merged

remove ARGV from Formula#all #15934

merged 1 commit into from Sep 2, 2023

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Sep 2, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

remove ARGV from Foumula because of #TODO

brew/Library/Homebrew/formula.rb

Line 1949 in de50e84

# TODO: ideally avoid using ARGV by moving to e.g. CLI::Parser

MikeMcQuaid
MikeMcQuaid approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @hyuraku, thanks again!

@MikeMcQuaid MikeMcQuaid merged commit f71e092 into Homebrew:master Sep 2, 2023
24 checks passed
@hyuraku hyuraku deleted the remove-ARGV-from-Formula.all branch September 2, 2023 12:14
Bo98
Bo98 reviewed Sep 2, 2023
View reviewed changes
Library/Homebrew/formula.rb
Comment on lines +34 to +35
require "cli/parser"
require "commands"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 @hyuraku can one of you submit a PR to remove if so?

@hyuraku hyuraku mentioned this pull request Sep 8, 2023
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyuraku @MikeMcQuaid @Bo98