Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: use Utils::Curl.curl_args #15935

Merged
merged 2 commits into from Sep 3, 2023
Merged

api: use Utils::Curl.curl_args #15935

merged 2 commits into from Sep 3, 2023

Conversation

MikeMcQuaid
Copy link
Member

This sets user-agent nicely and avoids some duplication.

@Bo98
Copy link
Member

Bo98 commented Sep 2, 2023

Looks like this reverts 0b3b54e. LGTM otherwise.

@apainintheneck
Copy link
Contributor

Could probably just modify this line to get the --quiet behavior back though it would affect all uses of curl which might not be what we want.

brew/Library/Homebrew/utils/curl.rb

Line 109 in 9b76182

args << "--silent" unless $stdout.tty?

@MikeMcQuaid
api: use Utils::Curl.curl_args
d5a1f3e 
This sets user-agent nicely and avoids some duplication.
@MikeMcQuaid
Copy link
Member Author

@Bo98 @apainintheneck Good points, have adjusted utils/curl accordingly and this looks like the right behaviour.

@MikeMcQuaid @apainintheneck
api: retry manually without curl_args defaults.
8ba3898 
Co-authored-by: Kevin <apainintheneck@gmail.com>
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 3, 2023
@MikeMcQuaid MikeMcQuaid merged commit fc72dfc into Homebrew:master Sep 3, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the api_curl_args branch September 3, 2023 13:31
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Bo98 Bo98 Awaiting requested review from Bo98

@apainintheneck apainintheneck Awaiting requested review from apainintheneck

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @Bo98 @apainintheneck @BrewTestBot