Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_auditor: relax version audit in taps #15972

Merged
merged 2 commits into from Sep 6, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 6, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The relaxes the version regex audit introduced in #15936 by disabling it for 3rd-party taps, to help address osrf/homebrew-simulation#2390 (see also #15936 (comment)). If this audit will be applied to 3rd-party taps, it would be nice to allow some time to comply, since bottles will need to be rebuilt.

Disable the version regex audit for 3rd-party taps,
at least for now to allow time to comply.
@scpeters scpeters mentioned this pull request Sep 6, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @scpeters!

I've added a term here to ensure we're also helping taps that may be using GitHub Packages to use the correct formats before we remove the workarounds here.

@MikeMcQuaid MikeMcQuaid merged commit 8d0f310 into Homebrew:master Sep 6, 2023
22 checks passed
@scpeters scpeters deleted the audit_version_core branch September 6, 2023 16:39
@scpeters
Copy link
Member Author

scpeters commented Sep 6, 2023

Thanks again @scpeters!

I've added a term here to ensure we're also helping taps that may be using GitHub Packages to use the correct formats before we remove the workarounds here.

thanks!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants