Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bump: reduce unnecessary output #16004

Merged
merged 2 commits into from Sep 14, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When using brew bump with --no-pull-requests, omit the open & closed pull requests lines which will always be "none" and may therefore be inaccurate.

Also added a method to always skip both head-only and disabled formulae. This fixes an issue that would occur with the command's non-argument form if a matched formula was head-only.

Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit b2cf50b into Homebrew:master Sep 14, 2023
24 checks passed
@EricFromCanada EricFromCanada deleted the bump-reduce-output branch September 14, 2023 14:31
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants