cmd/audit: improve performance of versioned formula names

[apainintheneck]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

There is a check for other versioned formula with the same name in the file audit. This just memoizes all of the versioned formulae in a tap during the first call and then uses that much shorter list every time it checks for things.

Command:

brew prof --  audit --skip-style --except=version,installed --tap=homebrew/core

Before:

After:

It results in a 5-10 second speed up locally for me.

Update: It looks like we're down to ~35 seconds in this repo's CI after this change and @Bo98's change in #16008.

[Bo98]

Yeah I had identified the same: https://github.com/Homebrew/brew/pull/16007/files#diff-61f7b22029742d3ce5a09055c06c73368cc9a06b965af5c172553731eb0855b6R650

Looks like your version is a little more fleshed out though.

[apainintheneck]

@Bo98 I'd overlooked that when reviewing your PR. My bad.

[apainintheneck]

It looks like this also speeds up formula API generation as well.

Before: (from #16008)

After:

[MikeMcQuaid]

Great work as usual @apainintheneck!

[zouchengli]

lima@lima-ubuntu-lts:~$ ruby -v
ruby 2.6.10p210 (2022-04-12 revision 67958) [aarch64-linux]

lima@lima-ubuntu-lts:~$ echo $PATH
/home/lima.linux/.rbenv/shims:/home/lima.linux/.rbenv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/sbin:/sbin:/usr/sbin:/sbin:/usr/sbin:/sbin:/home/lima.linux/.rbenv/versions/2.6.10/bin/

lima@lima-ubuntu-lts:~$ ./install.sh
==> Checking for sudo access (which may request your password)...
==> This script will install:
/home/linuxbrew/.linuxbrew/bin/brew
/home/linuxbrew/.linuxbrew/share/doc/homebrew
/home/linuxbrew/.linuxbrew/share/man/man1/brew.1
/home/linuxbrew/.linuxbrew/share/zsh/site-functions/_brew
/home/linuxbrew/.linuxbrew/etc/bash_completion.d/brew
/home/linuxbrew/.linuxbrew/Homebrew

Press RETURN/ENTER to continue or any other key to abort:
==> /usr/bin/sudo /bin/chown -R lima:lima /home/linuxbrew/.linuxbrew/Homebrew
==> Downloading and installing Homebrew...
HEAD is now at aa2a77b Merge pull request #16010 from apainintheneck/improve-versioned-formula-names-performance
Error: No Homebrew ruby 2.6.10_1 available for aarch64 processors!
Error: Failed to install Homebrew Portable Ruby and cannot find another Ruby 2.6.10!
If there's no Homebrew Portable Ruby available for your processor:

• install Ruby 2.6.10 with your system package manager (or rbenv/ruby-build)
• make it first in your PATH
• try again

Failed during: /home/linuxbrew/.linuxbrew/bin/brew update --force --quiet

[apainintheneck]

@zouchengli It's not obvious from the stack trace that this problem is related to this PR. Could you either make an issue in the install repo or open a discussion so that we can better troubleshoot this?

[zouchengli]

@zouchengli It's not obvious from the stack trace that this problem is related to this PR. Could you either make an issue in the install repo or open a discussion so that we can better troubleshoot this?

OK Please refer to Try install homebrew on arm64 ubuntu