Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/edit: make the warning easier to read #16024

Merged
merged 3 commits into from Sep 25, 2023
Merged

dev-cmd/edit: make the warning easier to read #16024

merged 3 commits into from Sep 25, 2023

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Sep 23, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@abitrolly
Make warning message fit 80 char limit
84ce25d 
The longest line below limit is 59 chars this way.

Warning: `brew install` ignores locally edited formulae if
`HOMEBREW_NO_INSTALL_FROM_API` is not set.
MikeMcQuaid
MikeMcQuaid approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @abitrolly!

@MikeMcQuaid MikeMcQuaid merged commit f1d345a into Homebrew:master Sep 25, 2023
24 checks passed
@abitrolly abitrolly deleted the patch-2 branch September 25, 2023 12:47
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apainintheneck apainintheneck apainintheneck left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abitrolly @MikeMcQuaid @apainintheneck