Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: don't recommend minitest extension. #16042

Merged
merged 1 commit into from Sep 27, 2023
Merged

rubocop: don't recommend minitest extension. #16042

merged 1 commit into from Sep 27, 2023

Conversation

MikeMcQuaid
Copy link
Member

We don't use or need it.

issyl0
issyl0 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just turn suggesting extensions off entirely?

@MikeMcQuaid MikeMcQuaid merged commit c2841e2 into Homebrew:master Sep 27, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rubocop_no_minitest branch September 27, 2023 11:47
@MikeMcQuaid
Copy link
Member Author

@issyl0 Some of them have been useful for us in the past e.g. Sorbet so it'd be nice to keep suggesting them in case new, useful ones are added.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @issyl0