Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/unbottled: speed up dependent fetching #16045

Merged
merged 1 commit into from Sep 27, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 27, 2023

This was quite slow before, for me at least.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would love any benchmarks, if you have any (not blocking for merge).

@Bo98
Copy link
Member Author

Bo98 commented Sep 27, 2023

Benchmark being "this is taking several minutes I give up" frustration to "this only takes a minute or two now" happiness 😅

Can do actual numbers in a bit.

@MikeMcQuaid MikeMcQuaid merged commit 5380fb7 into Homebrew:master Sep 27, 2023
25 checks passed
@Bo98 Bo98 deleted the unbottled-perf branch September 27, 2023 17:09
@p-linnane
Copy link
Member

I noticed this change when running brew unbottled without even seeing this PR. It reduced it from ~2 minutes to a matter of seconds for me. Thanks @Bo98 🎉

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants