Revert "service: support multiple sockets in DSL" #16054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apainintheneck
added
the
critical
BrewTestBot
approved these changes
Sep 28, 2023
|
Note: There are only 3 formulae that use sockets right now in the service DSL but it seemed good to revert anyway. It shouldn't affect many users. |
apainintheneck
deleted the
revert-16026-support-multiple-sockets-in-service-dsl
branch
1 task
|
Good catch, thanks for revert @apainintheneck! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16026
This changed the service socket serialization code which will make it not possible to generate valid plist files for formulae with those blocks until they update their brew version. Which is to say that the local brew code will not be up-to-date with the JSON API for non-developer users. I'll work on making it more backwards compatible after reverting.