fix eval (brew shellenv)
from exiting with status 1 in fish
#16068
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?fish's
set
doesn't modify the exit status when assigning a variable. This means thatset -q VAR; or set VAR ...
will return an exit status of 1 even if the variable is suceessfully set. By switching the commands to! set -q VAR; and set VAR ...
, this prevents the 1 from propogating when runningeval (brew shellenv)
.