Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eval (brew shellenv) from exiting with status 1 in fish #16068

Merged
merged 1 commit into from Oct 1, 2023

Conversation

J-M0
Copy link
Contributor

@J-M0 J-M0 commented Oct 1, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

fish's set doesn't modify the exit status when assigning a variable. This means that set -q VAR; or set VAR ... will return an exit status of 1 even if the variable is suceessfully set. By switching the commands to ! set -q VAR; and set VAR ..., this prevents the 1 from propogating when running eval (brew shellenv).

fish's `set` doesn't modify the exit status when assigning a variable.
This means that `set -q VAR; or set VAR ...` will return an exit status
of 1 even if the variable is suceessfully set. By switching the commands
to `! set -q VAR; and set VAR ...`, this prevents the 1 from propogating
when running `eval (brew shellenv)`.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @J-M0!

@MikeMcQuaid MikeMcQuaid merged commit affc4c0 into Homebrew:master Oct 1, 2023
27 checks passed
@J-M0 J-M0 deleted the fish-shellenv branch October 1, 2023 18:05
@buildpulse
Copy link

buildpulse bot commented Oct 1, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: affc4c0
Build URL: https://github.com/Homebrew/brew/actions/runs/6372388989/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream without print_stderr its result stderr is expected to eq "2\n4\n6\n"

@buildpulse
Copy link

buildpulse bot commented Oct 1, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: affc4c0
Build URL: https://github.com/Homebrew/brew/actions/runs/6372388989/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream with default options echoes only STDERR

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants