download_strategy: fix mirrors not working #16079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricFromCanada
added a commit
to EricFromCanada/brew
that referenced
this pull request
Oct 4, 2023
MikeMcQuaid
approved these changes
Oct 4, 2023
| begin | ||
| parsed_output = curl_headers(url.to_s, wanted_headers: ["content-disposition"], timeout: timeout) | ||
| rescue ErrorDuringExecution | ||
| return [url, parse_basename(url), nil, nil, false] |
There was a problem hiding this comment.
Required by your change but just a drive-by thought that this is a horrendous return signature that's dying to be a e.g. Hash or Struct.
There was a problem hiding this comment.
Yeah, agreed. Takes me a moment to understand everytime I look at it.
It's also difficult to change without breaking custom download strategies, so probably worth doing with a larger refactor with better public API.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15169.
Partially covers #15816.
Should cover #16078.