Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "standalone/bootsnap: relax restrictions" #16088

Merged
merged 1 commit into from Oct 5, 2023
Merged

Revert "standalone/bootsnap: relax restrictions" #16088

merged 1 commit into from Oct 5, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Oct 5, 2023
@MikeMcQuaid MikeMcQuaid merged commit de575da into master Oct 5, 2023
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the revert-16062-bootsnap-relax branch October 5, 2023 07:43
@buildpulse
Copy link

buildpulse bot commented Oct 5, 2023

Known disruptive tests have failed for this pull request.

Commit SHA: de575da
Build URL: https://github.com/Homebrew/brew/actions/runs/6416105056/attempts/1

Suite Name Test Name Details
rspec SystemCommand with both STDOUT and STDERR output from upstream with default options its result stderr is expected to eq "2\n4\n6\n" →

@Bo98
Copy link
Member

Bo98 commented Oct 5, 2023 •
edited

That looks like a general native gem issue that we had been lucky to had not already hit: #16089

@MikeMcQuaid MikeMcQuaid mentioned this pull request Oct 5, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @Bo98 @BrewTestBot