Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GHA permission for GitHub Packages #16105

Merged
merged 2 commits into from Oct 12, 2023

Conversation

davidchall
Copy link
Contributor

@davidchall davidchall commented Oct 12, 2023

Followup to #16097 (CC: @jameelkaisar). When a tap stores bottles in GitHub Packages, then the publish workflow requires the corresponding write permission.

The error message raised was: level=fatal msg="copying image 1/2 from manifest list: writing blob: initiating layer upload to /v2/davidchall/hep/fastjet/blobs/uploads/ in ghcr.io: denied: installation not allowed to Write organization package"

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When a tap stores bottles in GitHub Packages, then the publish workflow requires the corresponding write permission.
@davidchall davidchall marked this pull request as ready for review October 12, 2023 03:06
@davidchall
Copy link
Contributor Author

I'm unable to run brew typecheck and brew tests due to the following error:

Could not find gem 'sorbet-static (= 0.5.10461)' with platforms 'aarch64-linux', 'arm-linux',
'arm64-darwin', 'x86_64-darwin', 'x86_64-linux' in rubygems repository https://rubygems.org/ or installed
locally.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @davidchall!

@MikeMcQuaid MikeMcQuaid merged commit 5e5f5c9 into Homebrew:master Oct 12, 2023
27 checks passed
@jameelkaisar
Copy link
Contributor

Nice work 🙂

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
@davidchall davidchall deleted the patch-1 branch January 31, 2024 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants