Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/deps: show deps for head spec with --HEAD #16106

Merged
merged 1 commit into from Oct 13, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just adding the option is all it needed to work. Not sure if it should warn when a formula has no head spec. Also includes a few man page fixes.

$ brew deps --include-build --tree --annotate coreutils
coreutils
└── gmp 

$ brew deps --include-build --tree --annotate --HEAD coreutils
coreutils
├── gmp 
├── autoconf  [build]
│   └── m4 
├── automake  [build]
│   └── autoconf 
│       └── m4 
├── bison  [build]
├── gettext  [build]
├── texinfo  [build]
├── wget  [build]
│   ├── libidn2 
│   │   ├── libunistring 
│   │   ├── gettext 
│   │   └── pkg-config  [build]
│   ├── openssl@3 
│   │   └── ca-certificates 
│   └── pkg-config  [build]
└── xz  [build]

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@EricFromCanada
Copy link
Member Author

Added a warning if one or more of the named args has no head spec:

$ brew deps --include-build --annotate --HEAD --tree zssh zsh zoro 
Warning: No head spec for zoro or zssh, using stable spec instead
zoro
└── go  [build]

zsh
├── ncurses 
│   └── pkg-config  [build]
├── pcre 
└── autoconf  [build]
    └── m4 

zssh
├── lrzsz 
├── autoconf  [build]
│   └── m4 
├── automake  [build]
│   └── autoconf 
│       └── m4 
└── libtool  [build]
    └── m4 

@EricFromCanada EricFromCanada marked this pull request as ready for review October 13, 2023 04:33
@MikeMcQuaid MikeMcQuaid requested a review from Bo98 October 13, 2023 07:11
@MikeMcQuaid MikeMcQuaid merged commit b085889 into Homebrew:master Oct 13, 2023
28 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @EricFromCanada!

@EricFromCanada EricFromCanada deleted the cmd-deps-head branch October 13, 2023 12:27
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants