Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_strategy: support Mercurial tags/branches #16117

Merged
merged 1 commit into from Oct 17, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The pypy3.9 and pypy3.10 formulae each have a branch set for their Mercurial-based head URLs, but it turns out those have been ignored until now. This adds support for tag:, revision:, and branch: for Mercurial repository URLs, with which you can:

  1. add e.g. branch: "dev" to a head URL after using: :hg and it will work, e.g.: brew fetch --HEAD pypy3.10; hg branch --cwd $(brew --cache --HEAD pypy3.10) should print "py3.10" instead of "default"
  2. set a formula to fetch a release directly from a Mercurial tag, e.g.:
  url "https://hg.sr.ht/~breakfastquay/rubberband", using: :hg,
      tag:      "v3.3.0",
      revision: "55367f2e76c9"

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit 23ee8af into Homebrew:master Oct 17, 2023
27 checks passed
@EricFromCanada EricFromCanada deleted the hg-branches-tags branch October 21, 2023 16:48
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants