Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(global): update safari user-agent to latest #16127

Merged
merged 4 commits into from Oct 21, 2023
Merged

chore(global): update safari user-agent to latest #16127

merged 4 commits into from Oct 21, 2023

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@chenrui333
chore(global): update safari user-agent to latest
2c4b282 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title update safari user-agent to latest chore(global): update safari user-agent to latest Oct 20, 2023
@chenrui333
curl_spec: update test
4232cb6 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Bo98
Bo98 reviewed Oct 21, 2023
View reviewed changes
Library/Homebrew/global.rb Outdated
@@ -47,8 +47,8 @@
HOMEBREW_USER_AGENT_RUBY =
"#{ENV.fetch("HOMEBREW_USER_AGENT")} ruby/#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL}"
HOMEBREW_USER_AGENT_FAKE_SAFARI =
"Mozilla/5.0 (Macintosh; Intel Mac OS X 13_5_1) AppleWebKit/605.1.15 " \
"(KHTML, like Gecko) Version/16.5 Safari/605.1.15"
"Mozilla/5.0 (Macintosh; Intel Mac OS X 14_0) AppleWebKit/605.1.15 " \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Safari output this? I thought they froze it at 10_15_7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 You are right, it does not.

@MikeMcQuaid MikeMcQuaid merged commit 46a8310 into Homebrew:master Oct 21, 2023
27 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @chenrui333!

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenrui333 @MikeMcQuaid @Bo98