Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/pr-upload: fix gems not being installed with --upload-only #16144

Merged
merged 1 commit into from
Oct 26, 2023
Merged

dev-cmd/pr-upload: fix gems not being installed with --upload-only #16144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/dev-cmd/pr-upload.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
odie "No bottle JSON files found in the current working directory" if json_files.blank?
bottles_hash = bottles_hash_from_json_files(json_files, args)

Homebrew.install_bundler_gems!(groups: ["pr_upload"])

Check warning on line 95 in Library/Homebrew/dev-cmd/pr-upload.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/dev-cmd/pr-upload.rb#L95 

Added line #L95 was not covered by tests

unless args.upload_only?
bottle_args = ["bottle", "--merge", "--write"]
bottle_args << "--verbose" if args.verbose?
Expand Down Expand Up @@ -125,8 +127,6 @@

check_bottled_formulae!(bottles_hash)

Homebrew.install_bundler_gems!(groups: ["pr_upload", "style"])

safe_system HOMEBREW_BREW_FILE, *bottle_args

json_files = Dir["*.bottle.json"]
Expand Down