Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/setup-ruby.sh: add new command. #16147

Merged
merged 1 commit into from Oct 27, 2023
Merged

cmd/setup-ruby.sh: add new command. #16147

merged 1 commit into from Oct 27, 2023

Conversation

MikeMcQuaid
Copy link
Member

This command, a bit like install-bundler-gems, is intended to be run to ensure that the next invocation of brew will not need to try and install Ruby or Bundler gems.

@MikeMcQuaid
cmd/setup-ruby.sh: add new command.
a2cd92b 
This command, a bit like `install-bundler-gems`, is intended to be run
to ensure that the next invocation of `brew` will not need to try and
install Ruby or Bundler gems.
@MikeMcQuaid MikeMcQuaid requested a review from Bo98 October 27, 2023 08:28
@MikeMcQuaid MikeMcQuaid mentioned this pull request Oct 27, 2023
Merged
Bo98
Bo98 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Worth noting this is a cmd calling a dev-cmd so there may or may not be an argument this should be dev-cmd too.

@MikeMcQuaid
Copy link
Member Author

Thanks for the review!

Worth noting this is a cmd calling a dev-cmd so there may or may not be an argument this should be dev-cmd too.

It'll only call the dev-cmd if you've enabled HOMEBREW_DEVELOPER or HOMEBREW_RUBY3 (the latter of which will go away) so seems reasonable given that.

@MikeMcQuaid MikeMcQuaid merged commit e377968 into Homebrew:master Oct 27, 2023
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the setup-ruby branch October 27, 2023 12:00
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @Bo98