Sparkle: Surface more Item values #16158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Historically, the
Sparkle
strategy'sItem
struct has only included basic values from the appcast that are commonly useful. Over time we've selectively added/surfaced more values as we've encountered outliers that require use of different values in astrategy
block (e.g., #13368).We now need to use
minimumSystemValue
(e.g., Homebrew/homebrew-cask#158044), so this expands theItem
struct to include any appcast value that we could conceivably want to use in the future. This will hopefully save us from having to make more modifications to the struct (and related tests) before we can use a previously-unused value in astrategy
block.I did livecheck runs with/without these changes and the [JSON] output remains the same, as expected.
I will be creating a follow-up PR to reimplement the
#audit_livecheck_min_os
cask audit (to align with theSparkle
strategy's behavior) but we also need to be able to accessitem.minimum_system_version
there as well. I have that work finished and will create a PR for it if/when this one is merged.