Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Homebrew.system respect stderr #16163

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Small fix for one thing brought up in #16134 (comment).

This caused some JSON output to break recently which is not ideal.

The change here is to check if the output should be diverted to stderr based on the options passed to system. If :out => :err is passed, then we should send any verbose output to stderr as well.

$ brew ruby -e 'Homebrew.system("ls", :out => :err)' 2>| wc -c
     105
$ brew ruby -e 'Homebrew.system("ls")' | wc -c
     105

This caused some JSON output to break recently which is not ideal.

The change here is to check if the output should be diverted to
stderr based on the options passed to system. If `:out => :err`
is passed, then we should send any verbose output to stderr
as well.

```console
$ brew ruby -e 'Homebrew.system("ls", :out => :err)' 2>| wc -c
     105
$ brew ruby -e 'Homebrew.system("ls")' | wc -c
     105
```
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit 98e06d9 into Homebrew:master Oct 30, 2023
27 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants