utils/gems: make .homebrew_gem_groups writing atomic
#16170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
Bo98
changed the title
.homebrew_gem_groups writing atomic
BrewTestBot
approved these changes
Oct 30, 2023
Bo98
force-pushed
the
atomic-homebrew_gem_groups
branch
2 times, most recently
from
bedf08c
to
b38df40
Compare
Bo98
force-pushed
the
atomic-homebrew_gem_groups
branch
from
b38df40
to
a339b91
Compare
|
Thanks @Bo98. Yeh, I think it might make sense to make use of the locks we have already in Bash for some of this stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes issues when running two gem-installing commands parallel (reported on Slack).
I haven't locked around Bundler itself here. I possibly will if there's still issues.