Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: handle nil tap #16182

Merged
merged 1 commit into from Nov 5, 2023
Merged

formula_auditor: handle nil tap #16182

merged 1 commit into from Nov 5, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 5, 2023

This could happen if referencing a dependency that is installed but not present in any tap.

Previously, this would crash brew audit.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Nov 5, 2023
@Bo98 Bo98 enabled auto-merge November 5, 2023 01:12
@Bo98 Bo98 merged commit 930f24b into Homebrew:master Nov 5, 2023
28 checks passed
@Bo98 Bo98 deleted the formula_auditor-nil-tap branch November 5, 2023 01:17
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bo98 @BrewTestBot