utils/gems: improve behaviour (particularly with Ruby 3) #16199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
BrewTestBot
previously approved these changes
Nov 9, 2023
Bo98
reviewed
Nov 9, 2023
MikeMcQuaid
force-pushed
the
utils_gems_ruby3_tweaks
branch
from
232fe93
to
c03016d
Compare
MikeMcQuaid
removed
the
critical
Bo98
reviewed
Nov 9, 2023
Bo98
reviewed
Nov 9, 2023
MikeMcQuaid
force-pushed
the
utils_gems_ruby3_tweaks
branch
from
c03016d
to
7593fe8
Compare
- Use `Tempfile.new` with a mode argument to avoid the default behaviour of creating a file with mode 0600 (only user-readable). - Avoid writing the file if it already exists and the contents are unchanged.
MikeMcQuaid
force-pushed
the
utils_gems_ruby3_tweaks
branch
from
7593fe8
to
e9aae0f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tempfile.newwith a mode argument to avoid the default behaviour of creating a file with mode 0600 (only user-readable).