formulary: fix loading from taps

[amancevice]

check tapped_name for "/" instead of parsed name

Use tap.core_tap? instead of checking formula name

I'm not 100% sure this is the correct fix but from my reading of the code it seems plausible

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Got a sorbet error running brew typecheck and brew tests but since it's such a small change I hope that's not a deal breaker

[Bo98]

I reckon this should be tap.core_tap? rather than a name check.

[amancevice]

@Bo98 refactored with your suggestion

[Bo98]

Just to check: did you test that it fixes #16213 for you?

[amancevice]

Yes, brew reinstall hashicorp/tap/terraform correctly installed the tapped formula with my branch checked out

[Bo98]

Thanks!

[Rylan12]

I don't think this is the right solution since tap, in this case, is supposed to refer to the old tap. So comparing to homebrew/core will break tap migrations when homebrew/core isn't installed.

Instead, we need to pass the original tap to the FormulaAPILoader and check here based on the path (which reflects the actual formula file location). I've worked a fix into #16216

[amancevice]

sounds good to me, thanks for the quick fix, @Rylan12