Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: set XDG_CACHE_HOME to fix umask in GitHub Actions #16245

Merged
merged 1 commit into from Nov 22, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 21, 2023

#16242 wasn't applying to GitHub Actions.

That's because GitHub Actions force sets HOME to /github/home, which is a mounted directory with its own permissions. Avoid this for curl downloads by setting XDG_CACHE_HOME to the original home's .cache directory.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Nov 22, 2023
@Bo98 Bo98 merged commit f6a741b into Homebrew:master Nov 22, 2023
31 checks passed
@Bo98 Bo98 deleted the gha-umask-fix branch November 22, 2023 00:17
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants