Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/vendor-gems: trial using GitHub App token #16249

Merged
merged 1 commit into from Nov 22, 2023
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 22, 2023

Hard to test really prior to merging.

@Bo98
Copy link
Member Author

Bo98 commented Nov 22, 2023

Could also potentially remove the BrewTestBot commit signing and replace that with: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-bots. I believe that requires using the REST/GraphQL API to commit rather than git though, but we could have an action to do that.

Will have a think about it. First is seeing if this works anyway.

@Bo98 Bo98 merged commit aef456f into master Nov 22, 2023
30 checks passed
@Bo98 Bo98 deleted the vendor-gems-app branch November 22, 2023 17:29
@MikeMcQuaid
Copy link
Member

Could also potentially remove the BrewTestBot commit signing and replace that with: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-bots. I believe that requires using the REST/GraphQL API to commit rather than git though, but we could have an action to do that.

Seems like a nice idea! Less code (and secrets?) to maintain on our end.

@Bo98
Copy link
Member Author

Bo98 commented Nov 23, 2023

Certainly less secrets.

For code: yes and no a bit. There will probably need some new code to call any relevant APIs, but that would go into a common action, like the existing Homebrew/actions/git-try-push. But it would then reduce code in the workflows themselves (i.e. no more Homebrew/actions/setup-commit-signing, no git commit etc).

I'll try it out and demonstrate in Homebrew/actions.

Copy link

@KingSkybax KingSkybax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants