Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: add PIP_CACHE_DIR to build env #16250

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should give us a nice speed up when rebuilding the same pip package multiple times (esp useful to save CI time in python version bump PRs)

Timings for brew reinstall -s black:
Before (no cache): 47s
After (with cache): 28s

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and idea, thanks @branchvincent!

Library/Homebrew/formula.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 1b8207b into Homebrew:master Nov 23, 2023
27 checks passed
@branchvincent branchvincent deleted the pip-cache branch November 30, 2023 23:10
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants