Support the rc shell. Fixes #16264 #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(In my tests, changes to `shellenv.sh` weren't required, so I didn't bother.)
MikeMcQuaid
reviewed
Nov 29, 2023
Library/Homebrew/utils/shell.rb
Outdated
Comment on lines
138
to
139
| sig { params(str: String).returns(String) } | ||
| def rc_quote(str) |
There was a problem hiding this comment.
Could you refactor this a bit to share more code with sh_quote and csh_quote? All three methods are almost identical bar a line or two.
Thanks!
There was a problem hiding this comment.
Can we assume that Homebrew won’t ever have a ' in any printed file name? If so, sh_quote would even be sufficient.
The only "special" case about `rc` quoting is that strings that contain apostrophes need to contain double apostrophes instead. It seems unlikely that this will happen in Homebrew.
MikeMcQuaid
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @dertuxmalwieder!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(In my tests, changes to
shellenv.shweren't required, so I didn't bother.)brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Can't type check: Error: Sorbet is not currently supported under system Ruby on macOS Sonoma.