dev-cmd/bump-cask-pr: fix --sha256 #16273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't seem to do anything and was always fetching the remote sha256
There's more that could be done here to make it a bit smarter. It currently (intentionally but not ideally) refuses to use it when on_system blocks are present even if those blocks are actually just older macOS handling as it can't tell the difference between on_os and on_arch. I've just done enough here to get the base functionality back.