Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/update.sh: don't switch to master when updating to a tag #16283

Merged
merged 1 commit into from Dec 4, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 2, 2023

Fixes issues seen with the homebrew/brew:latest image where it doesn't have the stable branch setup so it does a detached 4.1.22 -> master -> stable. This PR avoids that intermediate master change by making that pull happen in the background to the working state.

The issues with homebrew/brew:latest will be fixed anyway with 4.1.23 when the vendored gems become a part of the tag, but this change is still worthwhile to prevent that class of issues in the future as downgrades generally don't work well with git and vendored gems. The checkout is also unnecessary I/O as we checkout stable immediately afterwards.

I will also look into fixing the branches in the Dockerfile (i.e. run brew update somewhere), which will also avoid the issue.

@Bo98 Bo98 merged commit 8fbe927 into Homebrew:master Dec 4, 2023
26 checks passed
@Bo98 Bo98 deleted the update-master-fix branch December 4, 2023 02:25
@MikeMcQuaid
Copy link
Member

Thanks @Bo98. For this, Homebrew/install and Homebrew/actions/setup-homebrew: we should probably be avoiding checking out master ever, really, even as an intermediate step.

@Bo98
Copy link
Member Author

Bo98 commented Dec 4, 2023

Yeah, this fixes brew update but Homebrew/install etc still do their own thing. Homebrew/install in particular is one that should probably change since it almost always results in downgrades.

@MikeMcQuaid
Copy link
Member

Homebrew/install in particular is one that should probably change since it almost always results in downgrades.

Agreed 👍🏻

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants