Fix style violations under newer RuboCop #16336
Conversation
| def depends_on(one, two) | ||
| if one.any_installed_keg | ||
| &.runtime_dependencies | ||
| &.any? { |dependency| dependency["full_name"] == two.full_name } | ||
| &.runtime_dependencies | ||
| &.any? { |dependency| dependency["full_name"] == two.full_name } |
| @@ -35,8 +35,7 @@ | |||
| end | |||
|
|
|||
| it "does not use older tags when requested not to", :needs_macos do | |||
| allow(Homebrew::EnvConfig).to receive(:developer?).and_return(true) | |||
| allow(Homebrew::EnvConfig).to receive(:skip_or_later_bottles?).and_return(true) | |||
| allow(Homebrew::EnvConfig).to receive_messages(developer?: true, skip_or_later_bottles?: true) | |||
There was a problem hiding this comment.
This is also quite nice.
Bo98
force-pushed
the
style-fixes-dec2023
branch
2 times, most recently
from
843eb8c
to
445e146
Compare
Bo98
force-pushed
the
style-fixes-dec2023
branch
from
445e146
to
5692c8e
Compare
There was a problem hiding this comment.
One very minor quibble here that can be addressed in another PR. Great job @Bo98!
| @@ -25,7 +25,7 @@ def self.paths | |||
| # Return all tokens for installed casks. | |||
| sig { returns(T::Array[String]) } | |||
| def self.tokens | |||
| paths.map(&:basename).map(&:to_s) | |||
| paths.map { |path| path.basename.to_s } | |||
There was a problem hiding this comment.
This feels a bit weird and unlike traditional Ruby patterns. Which cop suggested it?
There was a problem hiding this comment.
Performance/MapMethodChain. Two maps is slower than one.
There was a problem hiding this comment.
@Bo98 Yeh, feels like a micro-optimisation to me and not sure I agree with it really but: not enough to object.
There was a problem hiding this comment.
yeah, it might matter over the Formula API hash where we've seen the smallest of things become visible, but probably not for any of these.
There was a problem hiding this comment.
This could also be paths.map { _1.basename.to_s }, which is the most readable option imo (it avoids the duplication of map or path in the other styles).
There was a problem hiding this comment.
Personally I hate the _1 variables 😅
Separate PR than the actual version bump to make the diff somewhat digestable.