Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new Style/MutableConstant RuboCop offenses for Ruby 3.1 #16346

Merged
merged 1 commit into from Dec 17, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 16, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- A follow-up to de592af, resetting the previous disabled comments too.
issyl0 added a commit to Homebrew/homebrew-formula-analytics that referenced this pull request Dec 17, 2023
- Fixing tap syntax CI failures surfaced in Homebrew/brew#16346.
@issyl0 issyl0 merged commit 7e328d8 into Homebrew:master Dec 17, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

@issyl0 issyl0 deleted the dont-forget-about-rubocop-comments branch December 17, 2023 22:06
@Bo98 Bo98 mentioned this pull request Dec 18, 2023
11 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants