Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around recent Akamai/Microsoft issues #16349

Merged
merged 1 commit into from Dec 17, 2023
Merged

Work around recent Akamai/Microsoft issues #16349

merged 1 commit into from Dec 17, 2023

Conversation

unshare
Copy link
Contributor

@unshare unshare commented Dec 16, 2023

At the moment, Microsoft Office and related casks fail audit due to failure to fetch a product homepage from the main Microsoft site (https://www.microsoft.com/) served by Akamai CDN. The failure is severe and weird: no status code is received as the connection is reset.
The analysis revealed the issue is linked to User-Agent and Accept-Language headers parsing. Homebrew uses involved user agent strings and has language hardcoded as en.
The simplest workaround is to use a simple user agent string when checking homepage availability if the cask is in an audit exceptions list.

Merging this would fix Microsoft Office updates (including Homebrew/homebrew-cask#162671)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

At the moment, Microsoft Office and related casks fail audit due to
failure to fetch a product homepage from the main Microsoft site
(https://www.microsoft.com/) served by Akamai CDN.
The failure is severe and weird: no status code is received as the
connection is reset.
The analysis revealed the issue is linked to `User-Agent` and
`Accept-Language` headers parsing. Homebrew uses involved user agent
strings and has language hardcoded as `en`.
The simplest workaround is to use a simple user agent string when checking
homepage availability if the cask is in an audit exceptions list.

Merging this would fix Microsoft Office updates (including
Homebrew/homebrew-cask#162671)
@unshare unshare marked this pull request as ready for review December 16, 2023 19:22
@MikeMcQuaid MikeMcQuaid requested a review from a team December 17, 2023 15:24
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @unshare!

@MikeMcQuaid MikeMcQuaid merged commit fb7f1a2 into Homebrew:master Dec 17, 2023
24 checks passed
unshare added a commit to unshare/homebrew-cask that referenced this pull request Dec 17, 2023
Standalone applications installers are updated as well.
Microsoft Auto Updater is already updated.

Passing audit depends on merging a workaround into Homebrew itself
(Homebrew/brew#16349).
The only issue is homepage availability check. Otherwise, the update
just works.
@unshare unshare deleted the homepage-ua branch December 17, 2023 16:30
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants