-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new RuboCop for alphabetizing zap trash
array elements
#16365
Add a new RuboCop for alphabetizing zap trash
array elements
#16365
Commits on Dec 19, 2023
-
Add a new RuboCop for alphabetizing
zap trash
array elements- Part of issue 16323. - Previously this was being done manually by Cask maintainers. - While we're here, enforce that the `zap trash` path is not in `[]` if it only contains a single element. - This is buggy on actual Casks, hence the draft PR.
Configuration menu - View commit details
-
Copy full SHA for 8cf58e3 - Browse repository at this point
Copy the full SHA 8cf58e3View commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 73b3ace - Browse repository at this point
Copy the full SHA 73b3aceView commit details
Commits on Dec 22, 2023
-
Ignore
zap trash
stanzas with interpolation- Interpolating the version into a path is a common pattern, but the interpolations trip up the alphabetization autocorrect quite spectacularly, so let's ignore them (for now?).
Configuration menu - View commit details
-
Copy full SHA for f4754ba - Browse repository at this point
Copy the full SHA f4754baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f34accf - Browse repository at this point
Copy the full SHA f34accfView commit details -
Better detection and replacement of non-alphabetized arrays
- Use `sort_by` to sort the array, rather than comparing each element to the next. - This doesn't error with complaints about clobbering at all when run on `homebrew/cask`, hurray. And it also handles interpolations correctly, rather than ignoring them. Co-authored-by: Bevan Kay <email@bevankay.me>
Configuration menu - View commit details
-
Copy full SHA for b9f13fc - Browse repository at this point
Copy the full SHA b9f13fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb124f9 - Browse repository at this point
Copy the full SHA fb124f9View commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9070f6d - Browse repository at this point
Copy the full SHA 9070f6dView commit details
Commits on Jan 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a1cb62 - Browse repository at this point
Copy the full SHA 6a1cb62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 338e30f - Browse repository at this point
Copy the full SHA 338e30fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c9e6e4 - Browse repository at this point
Copy the full SHA 2c9e6e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4b4af4 - Browse repository at this point
Copy the full SHA e4b4af4View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dae9b0c - Browse repository at this point
Copy the full SHA dae9b0cView commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 779f1bb - Browse repository at this point
Copy the full SHA 779f1bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9bcb64 - Browse repository at this point
Copy the full SHA e9bcb64View commit details -
Configuration menu - View commit details
-
Copy full SHA for eec7a96 - Browse repository at this point
Copy the full SHA eec7a96View commit details
Commits on Jan 21, 2024
-
Remove the single-element array in
everything.json
used for Cask tests``` 1) Cask::Cask#to_h when loaded from cask file returns expected hash Failure/Error: expect(JSON.pretty_generate(hash)).to eq(expected_json) Diff: @@ -28,9 +28,7 @@ "uninstall": [ { "launchctl": "com.every.thing.agent", - "delete": [ - "/Library/EverythingHelperTools" - ], + "delete": "/Library/EverythingHelperTools", "kext": "com.every.thing.driver", "signal": [ [ @@ -103,7 +101,7 @@ ], "ruby_source_path": "Casks/everything.rb", "ruby_source_checksum": { - "sha256": "b2707d1952f02c3fa566b7ad2a707a847a959d36f51d3dee642dbe5deec12f27" + "sha256": "0c4af571cce1632fc6a3dcf3e75ba82a3283077ef12399428192c26f9d6f779b" } } # ./test/cask/cask_spec.rb:225:in `block (4 levels) in <top (required)>' # ./test/support/helper/spec/shared_context/homebrew_cask.rb:53:in `block (2 levels) in <top (required)>' ```
Configuration menu - View commit details
-
Copy full SHA for 8910d5a - Browse repository at this point
Copy the full SHA 8910d5aView commit details -
Move multi-line comments with the code they're 'attached' to
Co-authored-by: Bevan J. Kay <email@bevankay.me>
Configuration menu - View commit details
-
Copy full SHA for 458844a - Browse repository at this point
Copy the full SHA 458844aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f9eef - Browse repository at this point
Copy the full SHA d5f9eefView commit details -
Treat
zap
anduninstall
the same- Since `zap` can have more than just `trash`.
Configuration menu - View commit details
-
Copy full SHA for 693a27d - Browse repository at this point
Copy the full SHA 693a27dView commit details