Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/pypi: use python from formula #16367

Merged
merged 1 commit into from Dec 30, 2023
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 20, 2023

Sometimes the Python dependency tree will be impacted by the exact version of Python being used (most commonly relating to functionality provided/missing from stdlibs like importlib-metadata and tomllib)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sometimes the Python dependency tree will be impacted by the exact
version of Python being used (most commonly relating to functionality
provided/missing from stdlibs like `importlib-metadata` and `tomllib`)
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @cho-m!

@cho-m cho-m marked this pull request as ready for review December 24, 2023 16:27
@cho-m cho-m merged commit 04d8ae2 into Homebrew:master Dec 30, 2023
24 checks passed
@cho-m cho-m deleted the pypi-use-formula-py branch December 30, 2023 15:57
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants