Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER. #16368

Merged
merged 5 commits into from
Dec 21, 2023
Merged

sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER. #16368

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
907da26
sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER.
Kentzo Dec 20, 2023
f71189a
Revert "sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO…
Kentzo Dec 20, 2023
9b672b0
sudo: sudo_as_root should apply on top of HOMEBREW_SUDO_THROUGH_SUDO_…
Kentzo Dec 20, 2023
4783c5b
Fix syntax errors.
Kentzo Dec 20, 2023
5f7db2b
Fix syntax errors.
Kentzo Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions Library/Homebrew/system_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,8 @@ def sudo_prefix
*askpass_flags,
"-E", *env_args,
"--", "/usr/bin/sudo"]
elsif sudo_as_root?
user_flags += ["-u", "root"]
end
user_flags += sudo_as_root? ? ["-u", "root"] : []
Kentzo marked this conversation as resolved.
Show resolved Hide resolved
["/usr/bin/sudo", *user_flags, *askpass_flags, "-E", *env_args, "--"]
end

Expand Down