Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: split out checksum check #16370

Merged
merged 1 commit into from Dec 20, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 20, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I think this will allow us to extend audit skip so that we can approve confirmed checksum changes maybe adding a CI-confirmed-checksum-change tag.

Open to different naming.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The other case I can think of is the new formula notability checks.

CI-confirmed-checksum-change

Would love something like CI-checksum-confirmed-by-asking-upstream or something super explicit so that people don't just slap it on and ignore the message.

@MikeMcQuaid MikeMcQuaid merged commit dbc2546 into Homebrew:master Dec 20, 2023
24 checks passed
@cho-m cho-m deleted the audit-unconfirmed-checksum branch December 20, 2023 16:17
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants