Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "no public presence" as cask rejection reason #16379

Merged
merged 1 commit into from Dec 21, 2023

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should make it clearer for people submitting casks that Homebrew has no interest in being the sole distribution mechanism.

@SMillerDev SMillerDev requested a review from a team December 21, 2023 14:37
@MikeMcQuaid MikeMcQuaid merged commit 4a8d9ce into master Dec 21, 2023
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the SMillerDev-patch-1 branch December 21, 2023 14:56
@MikeMcQuaid
Copy link
Member

Thanks @SMillerDev!

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants