formula_cellar_checks: detect cpuid in static libs #16380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MikeMcQuaid
approved these changes
Dec 22, 2023
carlocab
reviewed
Dec 22, 2023
| @@ -324,6 +324,14 @@ def check_cpuid_instruction(formula) | |||
| cpuid_instruction?(file, objdump) | |||
| end | |||
|
|
|||
| hardlinks = Set.new | |||
| return if formula.lib.directory? && formula.lib.find.any? do |pn| | |||
| next false if pn.symlink? || pn.directory? || pn.extname != ".a" | |||
There was a problem hiding this comment.
I think we can use ruby-macho to identify static libraries. (Or otherwise parse the header manually...)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Related to Homebrew/homebrew-core#157146 where runtime CPU detection is done inside static library.
Here I am only looking for static libraries directly installed inside
libso will skip any installed intolibexecor symlinks whose realpath is outsidelib. Also not as accurate as dynamic library detection since only looking for file extension rather than contents.