Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/config: limit tap info output #16386

Merged

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#16385 (review)

We really only need to see info that is surprising or out of the norm. For that reason, we can skip showing the tap remote and the tap branch if they are what we expect them to be.

$ brew config
HOMEBREW_VERSION: 4.2.0-55-g857ab13
ORIGIN: https://github.com/Homebrew/brew
HEAD: 857ab132a2942c6519e8016b63c1d458ca2e90bf
Last commit: 3 minutes ago
Core tap HEAD: 2d28e828ac78151a5076fe1060beb53dabdaa02f
Core tap last commit: 63 minutes ago
Core tap JSON: 22 Dec 18:22 UTC
Core cask tap HEAD: 30d910ada9cd36305e6110130a8d6ee2e74e61f9
Core cask tap last commit: 59 minutes ago
Core cask tap JSON: 22 Dec 18:22 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_AUTOREMOVE: set
HOMEBREW_CASK_OPTS: []
HOMEBREW_DEVELOPER: set
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.F4lxiBJvUl/org.macosforge.xquartz:0
HOMEBREW_EDITOR: code
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.1.4 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: quad-core 64-bit ivybridge
Clang: 12.0.0 build 1200
Git: 2.24.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.7-x86_64
CLT: 12.0.0.32.29
Xcode: 12.4

Compare to the output in #16385.

We really only need to see info that is surprising or out of the norm.
For that reason, we can skip showing the tap remote and the tap branch
if they are what we expect them to be.
@apainintheneck apainintheneck merged commit 2cbe388 into Homebrew:master Dec 22, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

@apainintheneck thanks!

ORIGIN: https://github.com/Homebrew/brew

Could probably skip this too if we really wanted and it's the default but no big deal either way.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants