Create dedicated Attrable mixin for attr_ methods #16406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
approved these changes
Dec 28, 2023
MikeMcQuaid
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Looks good, good idea @dduugg. One chance for a cleanup, if possible (but might not me).
Library/Homebrew/attrable.rb
Outdated
| sig { params(attrs: Symbol).void } | ||
| def attr_rw(*attrs) | ||
| attrs.each do |attr| | ||
| module_eval <<-EOS, __FILE__, __LINE__+1 |
There was a problem hiding this comment.
Can this be done with define_method?
There was a problem hiding this comment.
Done! (I simplified it as well, taking advantage of instance_variable_get returning nil for unset ivars.)
MikeMcQuaid
approved these changes
Jan 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?attr_rwwas monkey-patched intoModule, polluting every namespace, despite being used in only three modules. This PR yanks it into a dedicated mixin,Attrable. I also moved inattr_predicate, bc it seemed like overkill to have a mixin for each. Finally, I stopped including them fromglobal, and required them only in the files where they are used.