Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: keep std_configure_args #16408

Merged
merged 1 commit into from Dec 28, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 28, 2023

Match homebrew-core preferences where we usually keep std_configure_args even if some args are unrecognized and where we pass any additional args before std_configure_args.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I think we usually only need to remove these options if upstream is using a non-autotools configure script which has strict failures on undefined options.

Match `homebrew-core` preferences where we usually keep
`std_configure_args` even if some args are unrecognized and
where we pass any additional args before `std_configure_args`.
@p-linnane p-linnane merged commit f3c687e into Homebrew:master Dec 28, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @cho-m and @p-linnane!

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
@cho-m cho-m deleted the formula_creator-configure branch March 5, 2024 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants