Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-python-resources: show pip install failure when --verbose #16412

Merged
merged 1 commit into from Dec 31, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 30, 2023

Also use --disable-pip-version-check to remove pip update notices

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Right now, brew update-python-resources will just give a generic:

Error: Unable to determine dependencies for "..." because of a failure when running ...
Please update the resources manually.

When trying to figure out reason, I found it useful to see the actual failure (which is currently hidden behind the HOMEBREW_STDERR variable, but setting that can lead to unwanted errors due to Sorbet).


Also worth setting --disable-pip-version-check to avoid some spam when showing stderr:

[notice] A new release of pip is available: 23.3.1 -> 23.3.2
[notice] To update, run: /opt/homebrew/opt/python@3.11/bin/python3.11 -m pip install --upgrade pip

Also use `--disable-pip-version-check` to remove pip update notices
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea thanks @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit 3bbce39 into Homebrew:master Dec 31, 2023
24 checks passed
@cho-m cho-m deleted the pypi-verbose branch December 31, 2023 17:57
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants